1. Forum
  2. FidoNet
  3. SYNC SYSOPS

  • "use strict" has no effect in qwk_sec.js and batchxfer.js

    From Rob Swindell@1:103/705 to GitLab issue in main/sbbs on Mon Sep 28 18:58:21 2026
    open https://gitlab.synchro.net/main/sbbs/-/work_items/1263

    In `exec/qwk_sec.js` (and `exec/batchxfer.js`, which it was modeled on), the `"use strict";` statement comes after a `require(...)` call, so it is not a directive prologue and has no effect: neither module actually runs in strict mode.

    To take effect it would have to be the first statement of the script (or of a function). Moving it may surface strict-mode errors in code that currently runs non-strict, so each module should be tested after the change.

    -- *Authored by Claude (Claude Code), on behalf of @rswindell*
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Sep 28 21:15:51 2026
    https://gitlab.synchro.net/main/sbbs/-/work_items/1263#note_10476

    Fixed for `exec/qwk_sec.js` in b47b4cb329 (vary-3-military, 2026-09-28): `"use strict";` is now the first statement of the file, so the module runs in strict mode. It was tested in strict mode (the scratch-server QWK menu test suite and a strict-mode unit test of its quit-key logic) with no errors.

    `exec/batchxfer.js` still has the same problem (`"use strict";` on line 8, after its `require()` calls), so this issue stays open for that file.

    -- *Authored by Claude (Claude Code), on behalf of @rswindell*
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab issue in main/sbbs on Mon Sep 28 21:18:01 2026
    close https://gitlab.synchro.net/main/sbbs/-/work_items/1263
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Sep 28 21:18:01 2026
    https://gitlab.synchro.net/main/sbbs/-/work_items/1263#note_10479

    Fixed for `exec/batchxfer.js` in 826fe27664 (hang-3-stamp, 2026-09-28): `"use strict";` is now the first statement of the file. Its two `const` declarations became `var` (one was re-declared on every pass of the menu loop).

    Tested by driving the batch menu through every command with non-empty upload and download queues, and by confirming that an undeclared assignment now throws (it passed silently before).

    With `qwk_sec.js` already fixed, both files named here are done; closing.

    -- *Authored by Claude (Claude Code), on behalf of @rswindell*
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)